Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(tianmu): impl bit type, add support to create/desc table with bit type #919 #1132

Merged
merged 10 commits into from
Jan 5, 2023
Merged

feat(tianmu): impl bit type, add support to create/desc table with bit type #919 #1132

merged 10 commits into from
Jan 5, 2023

Conversation

hustjieke
Copy link
Collaborator

@hustjieke hustjieke commented Dec 15, 2022 •
edited
Loading

Summary about this PR

[summary]

  1. add support to create table with bit type
  2. add support to desc/show fields with bit type table
  3. currently we design bit(M) with (1 <= M <= 63), in the future we'll expand prec to 64.

Tests Check List

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Changelog

  • New Feature
  • Bug Fix
  • Performance Improvement
  • Build/Testing/CI/CD
  • Documentation
  • Not for changelog (changelog entry is not required)

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features

@mergify
Copy link
Contributor

mergify bot commented Dec 15, 2022

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@mergify mergify bot added the PR-feature feature for pull request label Dec 15, 2022
@codecov
Copy link

codecov bot commented Dec 16, 2022 •
edited
Loading

Codecov Report

Base: 0.00% // Head: 43.29% // Increases project coverage by +43.29% 🎉

Coverage data is based on head (9fd645a) compared to base (345618f).
Patch coverage: 64.35% of modified lines in pull request are covered.

Additional details and impacted files 
@@                 Coverage Diff                  @@
##           stonedb-5.7-dev    #1132       +/-   ##
====================================================
+ Coverage                 0   43.29%   +43.29%     
====================================================
  Files                    0     1830     +1830     
  Lines                    0   396110   +396110     
====================================================
+ Hits                     0   171496   +171496     
- Misses                   0   224614   +224614
Impacted Files Coverage Δ
storage/tianmu/common/common_definitions.h 84.21% <ø> (ø)
storage/tianmu/core/bloom_block.cpp 0.00% <0.00%> (ø)
storage/tianmu/core/column.h 100.00% <ø> (ø)
storage/tianmu/core/engine.h 30.43% <ø> (ø)
storage/tianmu/core/joiner_hash.cpp 0.00% <0.00%> (ø)
storage/tianmu/core/parallel_hash_join.cpp 76.95% <ø> (ø)
storage/tianmu/core/parameterized_filter.cpp 77.18% <ø> (ø)
storage/tianmu/core/proxy_hash_joiner.cpp 0.00% <ø> (ø)
storage/tianmu/handler/ha_tianmu.cpp 57.04% <0.00%> (ø)
storage/tianmu/types/value_parser4txt.h 83.33% <ø> (ø)
... and 1864 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@hustjieke hustjieke self-assigned this Dec 16, 2022
@hustjieke hustjieke changed the title feat(tianmu): impl bit type, add support to create/desc table with bit type #919 [WIP]feat(tianmu): impl bit type, add support to create/desc table with bit type #919 Dec 16, 2022
@mergify
Copy link
Contributor

mergify bot commented Dec 16, 2022

This pull request's title should follow requirements next. @hustjieke please check it 👇.

Valid format:

fix(vc): fix sth..... (#3306)
  ^         ^---------^  ^----^
  |         |            |
  |         +            +-> you issue id.
  |         |
  |         +-> Summary in present tense.
  |
  +-------> Type: feat, fix, docs, workflow, style, refactor, test, website, chore

Valid types:

  • feat: new feature for stonedb
  • fix: bug fix for stonedb
  • docs: changes to the documentation
  • workflow: ci/cd in .github
  • perf: Changes to improve code performance
  • refactor: refactoring production code, eg. renaming a variable
  • style: formatting, missing semi colons, etc; no production code change
  • test: adding missing tests, refactoring tests; no production code change
  • website
  • chore: updating grunt tasks etc; no production code change

@hustjieke hustjieke force-pushed the feat_support_bit_type_issue919 branch from 566d50c to 81dc6d2 Compare December 20, 2022 07:55
@hustjieke hustjieke changed the title [WIP]feat(tianmu): impl bit type, add support to create/desc table with bit type #919 feat(tianmu): impl bit type, add support to create/desc table with bit type #919 Dec 20, 2022
@hustjieke hustjieke force-pushed the feat_support_bit_type_issue919 branch from 99d9a87 to f4405c4 Compare December 20, 2022 08:20
@hustjieke hustjieke marked this pull request as ready for review December 21, 2022 08:11
lujiashun
lujiashun approved these changes Dec 22, 2022
View reviewed changes
Copy link

@lujiashun lujiashun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

duanfuxiang0
duanfuxiang0 approved these changes Dec 22, 2022
View reviewed changes
Copy link
Contributor

@duanfuxiang0 duanfuxiang0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify
Copy link
Contributor

mergify bot commented Dec 22, 2022

This pull request has merge conflicts, you should resolve it before merged. @hustjieke please update it :)

Try @mergify update or update manually.

@hustjieke hustjieke force-pushed the feat_support_bit_type_issue919 branch from a680717 to 5a4e4b5 Compare December 23, 2022 01:54
@hustjieke hustjieke requested a review from wisehead December 23, 2022 02:11
@mergify
Copy link
Contributor

mergify bot commented Dec 26, 2022

This pull request has merge conflicts, you should resolve it before merged. @hustjieke please update it :)

Try @mergify update or update manually.

RingsC
RingsC suggested changes Dec 26, 2022
View reviewed changes
storage/tianmu/loader/parsing_strategy.cpp Outdated Show resolved Hide resolved
storage/tianmu/common/common_definitions.h Outdated Show resolved Hide resolved
mysql-test/suite/tianmu/t/create_table.test Show resolved Hide resolved
mysql-test/suite/tianmu/t/bit_type.test Show resolved Hide resolved
mysql-test/suite/tianmu/t/bit_type.test Show resolved Hide resolved
storage/tianmu/core/engine_convert.cpp Show resolved Hide resolved
storage/tianmu/core/pack_str.cpp Outdated Show resolved Hide resolved
storage/tianmu/core/tianmu_attr.cpp Outdated Show resolved Hide resolved
storage/tianmu/core/tianmu_table.cpp Outdated Show resolved Hide resolved
storage/tianmu/types/tianmu_num.cpp Outdated Show resolved Hide resolved
@hustjieke hustjieke force-pushed the feat_support_bit_type_issue919 branch from 5a4e4b5 to 38982a5 Compare December 27, 2022 09:23
RingsC
RingsC suggested changes Dec 28, 2022
View reviewed changes
storage/tianmu/core/aggregation_algorithm.cpp Show resolved Hide resolved
mysql-test/suite/tianmu/t/bit_type.test Show resolved Hide resolved
storage/tianmu/common/common_definitions.h Show resolved Hide resolved
storage/tianmu/common/txt_data_format.cpp Show resolved Hide resolved
storage/tianmu/core/data_type.cpp Outdated Show resolved Hide resolved
storage/tianmu/core/engine.cpp Outdated Show resolved Hide resolved
storage/tianmu/core/engine.cpp Show resolved Hide resolved
@hustjieke
feat(tianmu): impl bit type, add support to create/desc table with bi…
8e90f3d 
…t type stoneatom#919

[summary]
1. add support to create table with bit type
2. add support to desc/show fields with bit type table
3. currently we design bit(M) with (1 <= M <= 63), in the future we'll expand prec to 64.
@hustjieke
style(tianmu): renaming some variables based on google c++ style ston…
55b518d 
…eatom#11
@hustjieke
feat(tianmu): impl bit type on tianmu engine stoneatom#919
118937a 
[summary]
1. impl insert with mode delayed=0/1
2. impl simple select bit data from table
@hustjieke
feat(tianmu): support agg on bit types stoneatom#919
54a39f3
@hustjieke
fix ComputeNaturalSize and StaticExtrnalSize on bit calculate, used b…
8300075 
…y desc tables stoneatom#919
@hustjieke
style(tianmu): formatting code stoneatom#919
8dd5c0b
@hustjieke
feat(mtr): add bit test db during paralle executing stoneatom#919
5246253
@hustjieke
feat(tianmu): impl load bit type stoneatom#919
1775e53 
[summary]
impl load bit, including empty space and null value, to keep the src code integrity, we add
an bit parse function just like others numeric does.
@hustjieke
feat(tianmu): revert and adjust codes on bit stoneatom#919
b46effe 
[summary]
1. revert some vars renaming code to keep old style.
2. fix type cast using reinterpret_cast to avoid c-style casting.
3. add more test cases and fix some errors.
4. format code.
@hustjieke
feat(tianmu): rm some useless comment, bit type judge and add select.…
9fd645a 
…..where test case on bit types stoneatom#919
@hustjieke hustjieke force-pushed the feat_support_bit_type_issue919 branch from 38982a5 to 9fd645a Compare January 4, 2023 12:23
@mergify mergify bot merged commit f88fde8 into stoneatom:stonedb-5.7-dev Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lujiashun lujiashun lujiashun approved these changes

@duanfuxiang0 duanfuxiang0 duanfuxiang0 approved these changes

@RingsC RingsC RingsC approved these changes

@isredstar isredstar Awaiting requested review from isredstar

@wisehead wisehead Awaiting requested review from wisehead

Assignees

@hustjieke hustjieke

Labels
PR-feature feature for pull request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hustjieke @RingsC @duanfuxiang0 @lujiashun